Skip to content
All Skills

Mathlib PR

PR conventions for leanprover-community/mathlib4. Use when creating pull requests, writing commit messages, or managing labels for Mathlib contributions.

Software Engineering|v1|Updated 7/14/2026|GitHub source
MCP get_skill({ skillId: "mathlib-pr-d1124d91" })

Use this skill with your agent

Create a free account and connect via MCP

Get Started Free
# Mathlib PR Conventions

## Commit Message Format

PR titles follow `<type>(<scope>): <subject>`.

**Types:** `feat`, `fix`, `doc`, `style`, `refactor`, `test`, `chore`, `perf`, `ci`

**Scope** is the module path with the `Mathlib/` prefix stripped — e.g. `Data/Nat/Basic`, `Topology/Constructions`.

**Subject** uses imperative present tense, no capitalized first letter, no trailing period.

Full conventions: https://leanprover-community.github.io/contribute/commit.html

## Workflow

- PRs must come from **forks**, not branches on the main repo.
- Run `lake exe mk_all` when adding or removing files (updates the import root).
- PR dependencies use checkbox syntax in the description: `- [ ] depends on: #XXXX`
- Comment `!bench` on a PR to trigger performance benchmarking.

## Labels

Labels are added/removed via GitHub comments.

**Author-managed:**
- `awaiting-author` — reviewer feedback needs addressing
- `WIP` — work in progress
- `easy` — trivial PRs (single lemma, typo fix, <25 line diff)
- `help-wanted`, `please-adopt` — requesting help

**Topic:** `t-topology`, `t-algebra`, `t-combinatorics`, etc.

**Downstream projects:** `carleson`, `FLT`, etc.

**Automated:** `merge-conflict` is added/removed automatically when conflicts are detected or resolved.

## Merge Process

1. Reviewer approves and adds `maintainer-merge`
2. Maintainer adds `ready-to-merge`
3. Bors bot merges the PR

For **delegated** PRs (maintainer trusts author to finalize): the author comments `bors merge` to trigger the merge.

The review queue is at https://leanprover-community.github.io/queueboard/ — PRs with merge conflicts or pending CI don't appear there.

## Style and Naming

Before submitting, read the relevant guides — these are the authoritative references:

- **Naming conventions:** https://leanprover-community.github.io/contribute/naming.html
- **Code style:** https://leanprover-community.github.io/contribute/style.html
- **Documentation style:** https://leanprover-community.github.io/contribute/doc.html
- **PR lifecycle:** https://leanprover-community.github.io/contribute/index.html
#broad-capability#lean4#theorem-proving#math#formal-methods#mathlib#code#review

Related Skills

More skills in Software Engineering

Accessibility Standards

Comprehensive web accessibility standards based on WCAG 2.2 AA, with 38+ anti-patterns, legal enforcement context (EAA, ADA Title II), WAI-ARIA patterns, and framework-specific fixes for modern web frameworks and libraries.

#github-copilot#accessibilityMIT

Accord

Authoring unified specification packages across Business/Development/Design teams via staged elaboration (L0 Vision → L1 Requirements → L2 Team Detail → L3 Acceptance Criteria). No code. Use when authoring cross-team specs, building L0-L3 packages, or aligning Biz/Dev/Design on a single source of truth.

#broad-capability#developmentMIT

Acquire Codebase Knowledge

Use this skill when the user explicitly asks to map, document, or onboard into an existing codebase. Trigger for prompts like "map this codebase", "document this architecture", "onboard me to this repo", or "create codebase docs". Do not trigger for routine feature implementation, bug fixes, or narrow code edits unless the user asks for repository-level discovery.

#github-copilot#documentationMIT

Acreadiness Assess

Run the AgentRC readiness assessment on the current repository and produce a static HTML dashboard at reports/index.html. Wraps `npx github:microsoft/agentrc readiness` and hands off rendering to the @ai-readiness-reporter custom agent. Supports policies (--policy) for org-specific scoring. Use when asked to assess, audit, or score the AI readiness of a repo.

#github-copilot#planningMIT

Acreadiness Generate Instructions

Generate tailored AI agent instruction files via AgentRC instructions command. Produces .github/copilot-instructions.md (default, recommended for Copilot in VS Code) plus optional per-area .instructions.md files with applyTo globs for monorepos. Use after running /acreadiness-assess to close gaps in the AI Tooling pillar.

#github-copilot#skillMIT

Acreadiness Policy

Help the user pick, write, or apply an AgentRC policy. Policies customise readiness scoring by disabling irrelevant checks, overriding impact/level, setting pass-rate thresholds, or chaining org baselines with team overrides. Use when the user asks about strict mode, AI-only scoring, custom weights, CI gating, or wants org-wide standardisation.

#github-copilot#planningMIT